[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[RFC] bump min serf version, or degrade? (was: svn commit: r1302682 ...)

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 19 Mar 2012 18:11:08 -0400

Hey all,

With the change below, we can send all requests using Content-Length
rather than chunking. This is the core work for fixing issue 3979.

My question: should we simply bump the minimum serf to 1.1, or should
we just omit the Content-Length functionality? If the latter, then
users may run into 3979 if they have an older serf.

I'm thinking: bump our requirement. It will require packagers/distros
to get serf 1.1 packaged "soonish". (and no, it hasn't been released
yet)

Thoughts?

Cheers,
-g

On Mon, Mar 19, 2012 at 18:04, <gstein_at_apache.org> wrote:
> Author: gstein
> Date: Mon Mar 19 22:04:36 2012
> New Revision: 1302682
>
> URL: http://svn.apache.org/viewvc?rev=1302682&view=rev
> Log:
> Work on issue 3979: don't try to send chunked requests to HTTP/1.0
> servers. This will require serf 1.1.x and a new API.
>
> This commit lays all the groundwork, but doesn't change behavior yet.
> When HTTP/1.0 requests are needed, the request body will be placed
> into a spillbuf and then we use a new bucket type for the body which
> reads content out of the spillbuf. Meanwhile, the spillbuf gives us
> the total body size which we can place into a Content-Length header.
>...
Received on 2012-03-19 23:11:43 CET

This is an archived mail posted to the Subversion Dev mailing list.