[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1300623 - /subversion/trunk/subversion/tests/cmdline/svntest/main.py

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 14 Mar 2012 12:44:03 -0400

I don't see how this affects the logging at all. Before/after, you're
still calling _log_exception(), but now without a specified message.
In fact, won't this (now) generate an empty log message, followed by
the traceback?

Maybe you need to do something like:

  msg = traceback.format_exc()
  if fmt:
    logger.warn(fmt, *args)
  logger.warn(msg)

It may be that the first logger.warn() erased the traceback information.

Cheers,
-g

On Wed, Mar 14, 2012 at 12:32, <hwright_at_apache.org> wrote:
> Author: hwright
> Date: Wed Mar 14 16:32:20 2012
> New Revision: 1300623
>
> URL: http://svn.apache.org/viewvc?rev=1300623&view=rev
> Log:
> Make sure we print exception stack on all test failures.
>
> * subversion/tests/cmdline/svntest/main.py
>  (_log_exception): Don't require a message.
>  (TestRunner.run): Log the exception stack on a generic failure.
>
> Modified:
>    subversion/trunk/subversion/tests/cmdline/svntest/main.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/svntest/main.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/main.py?rev=1300623&r1=1300622&r2=1300623&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/svntest/main.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/svntest/main.py Wed Mar 14 16:32:20 2012
> @@ -994,7 +994,7 @@ def use_editor(func):
>   os.environ['SVNTEST_EDITOR_FUNC'] = func
>   os.environ['SVN_TEST_PYTHON'] = sys.executable
>
> -def _log_exception(fmt, *args):
> +def _log_exception(fmt='', *args):
>   logger.warn(fmt, *args)
>   logger.warn(traceback.format_exc())
>
> @@ -1345,6 +1345,8 @@ class TestRunner:
>                           ex.__class__.__name__, ex_args)
>         else:
>           _log_exception('EXCEPTION: %s', ex.__class__.__name__)
> +      else:
> +        _log_exception()
>     except KeyboardInterrupt:
>       logger.error('Interrupted')
>       sys.exit(0)
>
>
Received on 2012-03-14 17:44:37 CET

This is an archived mail posted to the Subversion Dev mailing list.