[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Call stack with new testsuite logging?

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 14 Mar 2012 11:08:40 -0500

On Wed, Mar 14, 2012 at 10:47 AM, Greg Stein <gstein_at_gmail.com> wrote:
> Away from laptop right now, but the trace can be printed using
> logger.exception(). Not sure where to insert it, but that is the key method.

logger.execption() always logs at the ERROR level, and we (I?) are
aiming to keep test failure output logging at the WARN level (ERROR is
reserved for errors in the test suite itself).

svntest.main._log_exception() will log at the WARN level.

-Hyrum

>
> On Mar 14, 2012 11:12 AM, "Philip Martin" <philip_at_codematters.co.uk> wrote:
>>
>> Philip Martin <philip_at_codematters.co.uk> writes:
>>
>> > Philip Martin <philip.martin_at_wandisco.com> writes:
>> >
>> >> Philip Martin <philip.martin_at_wandisco.com> writes:
>> >>
>> >>> Hyrum K Wright <hyrum.wright_at_wandisco.com> writes:
>> >>>
>> >>>> Agreed that the stack trace is important here.  Do you know in which
>> >>>> revision it disappeared?
>> >>>
>> >>> When I sync'd the branch with the trunk :-P
>> >>>
>> >>> I'll have a look.
>> >>
>> >> r1297676 produces a Python stack trace, r1297712 does not.
>> >
>> > Ooops!  r1297676 is just an error in the testsuite, not a stack trace
>> > for a failing test.
>>
>> So it's really r1297661 that produces a Python stack trace:
>>
>> svn: warning: W160040: No lock on path '/iota' in filesystem
>> '/home/pm/sw/subversion/obj2/subversion/tests/cmdline/svn-test-work/repositories/lock_tests-8/db'
>> Traceback (most recent call last):
>>  File
>> "/home/pm/sw/subversion/src2/subversion/tests/cmdline/svntest/main.py", line
>> 1323, in run
>>    rc = self.pred.run(sandbox)
>>  File
>> "/home/pm/sw/subversion/src2/subversion/tests/cmdline/svntest/testcase.py",
>> line 176, in run
>>    return self.func(sandbox)
>>  File "../../../../src2/subversion/tests/cmdline/lock_tests.py", line 338,
>> in handle_defunct_lock
>>    file_path_b)
>>
>> r1297676 doesn't run properly and r1297712 has no stack trace.
>>
>> --
>> Philip

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-03-14 17:35:52 CET

This is an archived mail posted to the Subversion Dev mailing list.