Re: svn commit: r1296604 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c

Stefan Fuhrmann <eqfox_at_web.de> writes:

> On 06.03.2012 10:43, Philip Martin wrote:
>> Perhaps the read routines could be changed to always read the
>> revprop-gen file and refresh the cache if required. Obviously this
>> would involve more IO than the current caching strategy, but it would
>> still be more efficient than the the previous non-cached approach.
>>
> Actually, this is a good idea -- maybe with
> some lower rating on "style" (adding a one-
> liner to most of the FS_FS API functions).
>
> And we don't have to actually re-read the
> revprop-gen file but only need to invalidate
> the cached revprop-gen value. Only the
> next time we read some revprop, will the
> generation info be read from file again.
>
> I'll implement that in the next couple of days.

I don't quite follow. I was thinking that the function that retrieves
the value from the cache would check the revprop-gen file, so only that
one function changes. It does reread the revprop-gen file, and if
necessary rereads the revprop file. I suppose the write function might
also change so that if the cache is known to be out-of-date then reading
revprop-gen can be skipped.

You seem to be describing something else?

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com