[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Revision 1297676 broke --list option of command line tests

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Tue, 6 Mar 2012 15:44:16 -0600

On Tue, Mar 6, 2012 at 3:27 PM, Alexey Neyman <stilor_at_att.net> wrote:
> The code which accesses options.verbose is still there in some places,
> including TestRunner.list():
>
> 1071809     pburba       # If there is no filter or this test made if through
> 1071809     pburba       # the filter then print it!
> 1071809     pburba       if options.milestone_filter is None or len(issues):
> 1071809     pburba         if options.verbose and self.pred.inprogress:
> ...
>
> Shouldn't all the options.verbose instances be removed _before_ changing the
> option handler to 'callback'?

In retrospect, yes.

I guess I'm still in my "run the tests, oh it passes, commit it" way
of working as I withdraw from the long slog of Ev2 compat shims.

And I'm lazy, as Greg likes to point out. ;)

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-03-06 22:44:48 CET

This is an archived mail posted to the Subversion Dev mailing list.