[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1296586 - /subversion/trunk/subversion/libsvn_client/externals.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 3 Mar 2012 04:32:23 -0500

Ah! Not "misplaced", but "does not apply". That makes more sense.

From your log msg, I thought you meant "this docstring shouldn't be
*here*. it should go *there*." ... and so I was confused because there
is never a "there" for a static function.

Thx,
-g

On Sat, Mar 3, 2012 at 04:29, Daniel Shahaf <danielsh_at_elego.de> wrote:
> In short: the docstring was removed because it didn't belong to the
> function it was placed next to.
>
> (and I couldn't find the function it did belong to)
>
> Daniel Shahaf wrote on Sat, Mar 03, 2012 at 11:26:43 +0200:
>> On some other static function, which implements the svn_hash_diff_func_t
>> interface and takes formal parameters named BATON and KEY.
>>
>> Greg Stein wrote on Sat, Mar 03, 2012 at 04:00:16 -0500:
>> > Huh? That is a static function. Where else would the doc string go?
>> > On Mar 3, 2012 3:28 AM, <danielsh_at_apache.org> wrote:
>> >
>> > > Author: danielsh
>> > > Date: Sat Mar  3 08:27:59 2012
>> > > New Revision: 1296586
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1296586&view=rev
>> > > Log:
>> > > * subversion/libsvn_client/externals.c
>> > >  (handle_externals_change): Remove a misplaced docstring.
>> > >
>> > > Modified:
>> > >    subversion/trunk/subversion/libsvn_client/externals.c
>> > >
>> > > Modified: subversion/trunk/subversion/libsvn_client/externals.c
>> > > URL:
>> > > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/externals.c?rev=1296586&r1=1296585&r2=1296586&view=diff
>> > >
>> > > ==============================================================================
>> > > --- subversion/trunk/subversion/libsvn_client/externals.c (original)
>> > > +++ subversion/trunk/subversion/libsvn_client/externals.c Sat Mar  3
>> > > 08:27:59 2012
>> > > @@ -781,10 +781,6 @@ wrap_external_error(const struct externa
>> > >   return err;
>> > >  }
>> > >
>> > > -/* This implements the 'svn_hash_diff_func_t' interface.
>> > > -   BATON is of type 'struct handle_externals_desc_change_baton *'.
>> > > -   KEY is a 'const char *'.
>> > > -*/
>> > >  static svn_error_t *
>> > >  handle_externals_change(const struct external_change_baton_t *eb,
>> > >                         const char *local_abspath,
>> > >
>> > >
>> > >
Received on 2012-03-03 10:32:55 CET

This is an archived mail posted to the Subversion Dev mailing list.