[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1296419 - /subversion/trunk/subversion/libsvn_client/commit.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 2 Mar 2012 15:01:19 -0500

On Fri, Mar 2, 2012 at 14:57, <hwright_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/commit.c Fri Mar  2 19:57:22 2012
> @@ -671,6 +671,7 @@ get_ra_editor(svn_ra_session_t **ra_sess
>   SVN_ERR(svn_client__ensure_revprop_table(&commit_revprops, revprop_table,
>                                            log_msg, ctx, pool));
>
> +#ifdef ENABLE_EDITOR_SHIMS
>   /* We need this for the shims. */
>   if (base_dir_abspath)
>     {
> @@ -686,6 +687,7 @@ get_ra_editor(svn_ra_session_t **ra_sess
>     }
>   else
>     anchor_abspath = NULL;
> +#endif
>
>   /* Fetch RA commit editor. */
>   SVN_ERR(svn_ra__register_editor_shim_callbacks(*ra_session,

The above code will pass an uninitialized ANCHOR_ABSPATH into
svn_ra__register_editor_shim_callbacks().

I'd suggested shifting the #endif down a few lines.

Cheers,
-g
Received on 2012-03-02 21:01:52 CET

This is an archived mail posted to the Subversion Dev mailing list.