[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1296201 - /subversion/trunk/subversion/libsvn_client/util.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Fri, 2 Mar 2012 08:16:21 -0600

On Fri, Mar 2, 2012 at 8:14 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> hwright_at_apache.org wrote on Fri, Mar 02, 2012 at 13:42:12 -0000:
>> Author: hwright
>> Date: Fri Mar  2 13:42:11 2012
>> New Revision: 1296201
>>
>> URL: http://svn.apache.org/viewvc?rev=1296201&view=rev
>> Log:
>> * subversion/libsvn_client/util.c
>>   (fetch_props_func): Return an empty prop hash, rather than a NULL one.
>>
>
> Why?

Because callers expect it?

>
>> Modified:
>>     subversion/trunk/subversion/libsvn_client/util.c
>>
>> Modified: subversion/trunk/subversion/libsvn_client/util.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/util.c?rev=1296201&r1=1296200&r2=1296201&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_client/util.c (original)
>> +++ subversion/trunk/subversion/libsvn_client/util.c Fri Mar  2 13:42:11 2012
>> @@ -262,7 +262,7 @@ fetch_props_func(apr_hash_t **props,
>>       working copy, and hence no method of fetching the requisite information. */
>>    if (!scb->anchor_abspath)
>>      {
>> -      *props = NULL;
>> +      *props = apr_hash_make(result_pool);
>>        return SVN_NO_ERROR;
>>      }
>>
>>
>>

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-03-02 15:16:54 CET

This is an archived mail posted to the Subversion Dev mailing list.