[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1296056 - /subversion/trunk/subversion/libsvn_client/util.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 2 Mar 2012 07:20:53 -0500

On 03/02/2012 01:03 AM, Greg Stein wrote:
> On Fri, Mar 2, 2012 at 01:01, Greg Stein <gstein_at_gmail.com> wrote:
>> On Fri, Mar 2, 2012 at 00:47, Greg Stein <gstein_at_gmail.com> wrote:
>> Looking more into this, the shims should accept an "anchor_url" and if
>> they receive a URL in the copyfrom_path, then it should turn that URL
>> into a relpath from that anchor. And *then* invoke the callback.
>>
>> IOW, I think the original bug is that a URL is passed into
>> ev1->add_file(copyfrom_path). The shim should strip that down to a
>> relpath before invoking the callback.
>
> And replying to myself one more time... :-)
>
> Yes, I know that the delta editor spec allows a URL to be passed as
> that parameter. But I don't think we should propagate it into the
> callbacks. Messy.

Just to add, you know, a second voice to this already lengthy conversation
:-): that Ev1 add_file/dir allows URLs is definitely confusing at times.
The need for it is fairly obvious, though: sometimes you have to copy from
a location that's outside the edit tree, requiring either an absolute path
reference (such as a URL) or a relative path with '..' components. URLs
were the obvious first choice.

If Ev2 can handle such cases without using URLs, +1 to barring their
introduction into the supported parameter set.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2012-03-02 13:21:57 CET

This is an archived mail posted to the Subversion Dev mailing list.