[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1296056 - /subversion/trunk/subversion/libsvn_client/util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 2 Mar 2012 00:47:40 -0500

On Mar 2, 2012 12:33 AM, <hwright_at_apache.org> wrote:
>
> Author: hwright
> Date: Fri Mar 2 05:33:22 2012
> New Revision: 1296056
>
> URL: http://svn.apache.org/viewvc?rev=1296056&view=rev
> Log:
> In the client-side ra Ev2 shim callbacks, make sure we handle copyfrom
paths
> correctly.
>
> Current number of test failures over ra_svn: 357
>
> * subversion/libsvn_client/util.c
> (fetch_props_func, fetch_kind_func, fetch_base_func): Detect and
appropriately
> munge copyfrom urls as paths.

Woah... wait a second. How did a URL get into the callback? I really think
these callbacks should have a single semantic: relpath. But why should we
continue the client monstrosity of "maybe path; maybe URL".

???

This change seems to paper over a URL leaking into the callbacks. That
doesn't seem right.

Cheers,
-g
Received on 2012-03-02 06:48:20 CET

This is an archived mail posted to the Subversion Dev mailing list.