Re: svn commit: r1294646 - /subversion/trunk/subversion/tests/cmdline/svndumpfilter_tests.py

Greg Stein wrote:

> Couldn't you just make a Posix-specific test for pattern=* testing?
> That would give us at least *some* testing coverage for it.

My patch was all about fixing the plain prefix (non-pattern) mode, and there is already a test for the pattern mode with pattern=/A/D/G/* so no compelling reason to add a pattern=* test.  Yes it would always be good to add an extra test, be it posix-only or whatever, if anyone wants to, but my task is complete.

- Julian

> julianfoad_at_apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=1294646&view=rev
>> Log:
>> Fix the new svndumpfilter test on Windows. A follow-up to r1294583.
>>
>> * subversion/tests/cmdline/svndumpfilter_tests.py
>>  (match_empty_prefix_or_pattern): Rename to 'match_empty_prefix'
>>    and stop testing the '--pattern' option with wildcards, as there
>> doesn't seem to be an easy way to make wildcards work consistently on
>> Windows and this part of the behaviour wasn't broken.
Received on 2012-02-29 09:05:05 CET