[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svnmucc component Re: [Issue 4131] New - svnmucc uses Subversion-private APIs

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 29 Feb 2012 10:03:57 +0200

danielsh_at_tigris.org wrote on Tue, Feb 28, 2012 at 23:59:51 -0800:
> http://subversion.tigris.org/issues/show_bug.cgi?id=4131
> Issue #|4131
> Summary|svnmucc uses Subversion-private APIs
> Component|subversion
> Version|1.6.x
> Platform|All
> URL|
> OS/Version|All
> Status|NEW
> Status whiteboard|
> Keywords|
> Resolution|
> Issue type|TASK
> Priority|P3
> Subcomponent|tools

Can someone create a 'svnmucc' component please?

> Assigned to|issues_at_subversion
> Reported by|danielsh
>
>
>
>
>
>
> ------- Additional comments from danielsh_at_tigris.org Tue Feb 28 23:59:50 -0800 2012 -------
> svnmucc uses the Subversion-private API's, svn_cmdline__apply_config_options()
> and svn_cmdline__parse_config_option(). However, as a tools/ project it should
> use only public API's where possible:
>
> % cd tools
> % grep \#include **/*.c | grep private
> client-side/svnmucc/svnmucc.c:#include "private/svn_cmdline_private.h"
> dev/svnraisetreeconflict/main.c:#include "private/svn_wc_private.h"
> dev/svnraisetreeconflict/main.c:#include "svn_private_config.h"
> server-side/svn-rep-sharing-stats.c:#include "svn_private_config.h"
>
> This could be fixed either by making svnmucc a core binary

Honestly, shall we move it to subversion/svnmucc/ already?

The test suite relies on it, ASF infra now relies on it, it's about to
have its own issue tracker component...

I'll get it done.

> (subversion/svnmucc/svnmucc.c) or by promoting those API's to be public (which
> involves more work than just renaming things: a constructor for
> svn_cmdline__config_argument_t would need to be created, and perhaps the warning
> handling changed).
Received on 2012-02-29 09:04:45 CET

This is an archived mail posted to the Subversion Dev mailing list.