[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Failing svnrdump_tests.py#43 with 1.7.x on Windows

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 09 Feb 2012 09:45:08 +0000

Johan Corveleyn <jcorvel_at_gmail.com> writes:

> DBG: dump_editor.c: 756: close_file 0112B188
> DBG: dump_editor.c: 552: add_file trunk/D/H/psi
> DBG: dump_editor.c: 725: apply_textdelta 0112B188
> DBG: dump_editor.c: 633: change_dir_prop 01150F00
> DBG: dump_editor.c: 633: change_dir_prop 01150F00
> DBG: dump_editor.c: 633: change_dir_prop 01150F00
> DBG: dump_editor.c: 633: change_dir_prop 01150F00
> DBG: dump_editor.c: 633: change_dir_prop 01150F00
> DBG: dump_editor.c: 518: close_directory 01150F00
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 756: close_file 0112B188

> DBG: dump_editor.c: 552: add_file trunk/D/H/psi
> DBG: dump_editor.c: 725: apply_textdelta 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 675: change_file_prop 0112B188
> DBG: dump_editor.c: 756: close_file 0112B188

So this is what I expected, the problem is the close_directory between
open_file and close_file. Because svnrdump doesn't implement a file
baton but instead just uses the edit baton to handle a single file, the
close_directory causes the file properties to be written early while the
text is written later in close_file.

What I don't understand is how close_directory gets called between
open_file and close_file. When libsvn_ra_serf calls open_file it does
so from libsvn_ra_serf/update.c:handle_fetch and later in that same
close_file is called. How does close_directory get invoked between the
two? What is the callstack when close_directory is called?

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2012-02-09 10:45:53 CET

This is an archived mail posted to the Subversion Dev mailing list.