[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Why do we check the base checksum so often?

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Mon, 6 Feb 2012 14:54:19 -0600

On Mon, Feb 6, 2012 at 2:49 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Mon, Feb 6, 2012 at 15:44, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> On 02/06/2012 03:41 PM, Greg Stein wrote:
>>> That is certainly an easier approach. "You use the old interface?
>>> Fine. You won't get base checksum verification cuz we'll always pass
>>> NULL." ... that seems like a fine position to take.
>>
>> This might be a fine position to take for some third-party consumer of the
>> APIs, but I hope you aren't advocating that we toss out such a core data
>> integrity check within Subversion itself.  Are you?
>
> Theoretically, we'll be converted over to Ev2 and the compatibility
> shim will not be used in our product. Only third-parties who choose to
> stick to the old Ev1 (delta editor) interfaces will lose the integrity
> check.

And I'll note that the base checksum check is superfluous, as the
resulting contents check is still valid and being performed.

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-02-06 21:54:53 CET

This is an archived mail posted to the Subversion Dev mailing list.