[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1239553 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h svn/diff-cmd.c svn/log-cmd.c svn/main.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Thu, 2 Feb 2012 07:13:46 -0600

On Thu, Feb 2, 2012 at 5:35 AM, <stsp_at_apache.org> wrote:
> Author: stsp
> Date: Thu Feb  2 11:35:09 2012
> New Revision: 1239553
>
> URL: http://svn.apache.org/viewvc?rev=1239553&view=rev
> Log:
> Add --no-diff-properties and --patch options to 'svn diff'.
> The --patch option implies --no-diff-properties and --show-copies-as-adds.

Bikeshed: since the fact that we are using diff is implied by the
subcommand, would it be reasonable to use a more generic option name,
such as '--ignore-props' instead of '--no-diff-properties'. It is
shorter firstly, and second it could be reused for other options, such
as log, or event commit.

I agree about the utility of the feature in general.

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-02-02 14:14:20 CET

This is an archived mail posted to the Subversion Dev mailing list.