[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav_svn__insert_all_liveprops asks for directory checksums

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 2 Feb 2012 14:46:40 +0200

Philip Martin wrote on Thu, Feb 02, 2012 at 12:07:54 +0000:
> Greg Stein <gstein_at_gmail.com> writes:
>
> > On Mon, Jan 30, 2012 at 12:00, Philip Martin <philip.martin_at_wandisco.com> wrote:
> >>...
> >> opeartions may trigger this code.  Should dav_svn__insert_all_liveprops
> >> be determining the node type before requesting a checksum?
> >
> > Yes, I believe that makes sense. The dav plugin should not define a
> > checksum property for directory resources.
>
> So at present dav_svn__insert_all_liveprops calls insert_prop_internal
> which calls svn_fs_file_checksum whatever the type of the node. I
> suppose we either check the node kind explicitly:
>
> svn_fs_check_path(&kind)
> if (kind == file)
> svn_fs_file_checksum(&checksum)

+1

>
> or catch the NOT_FILE error:
>
> err = svn_fs_file_checksum(&checksum)
> if (err == NOT_FILE)
> return
>
> --
> uberSVN: Apache Subversion Made Easy
> http://www.uberSVN.com
Received on 2012-02-02 13:47:21 CET

This is an archived mail posted to the Subversion Dev mailing list.