[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1228371 - in /subversion/trunk/subversion: svnadmin/main.c tests/cmdline/svnadmin_tests.py tests/cmdline/svntest/main.py

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 6 Jan 2012 16:09:16 -0500

On Jan 6, 2012 4:06 PM, "Daniel Shahaf" <danielsh_at_elego.de> wrote:
>
> Greg Stein wrote on Fri, Jan 06, 2012 at 15:56:29 -0500:
> > On Fri, Jan 6, 2012 at 14:50, <cmpilato_at_apache.org> wrote:
> > > Author: cmpilato
> > > Date: Fri Jan 6 19:50:30 2012
> > > New Revision: 1228371
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1228371&view=rev
> > > Log:
> > > Finish issue #4092 ("Add 'svnadmin unlock' subcommand which provides a
> > > lock token for unlock validation").
> >
> > The requirement to specify a username/token seems a bit silly. If you
> > have access to svnadmin, then you can just 'svnadmin lslocks' and feed
> > that information into the command.
> >
> > I would recommend simplifying the command to just require the path.
> > This is the *administrator* that you're talking about. The
> > double-checks for a username/token are a bit silly for the admin.
> >
>
> 'svnadmin rmlocks' removes the lock on PATH, unconditionally.
>
> 'svnadmin unlock PATH USER TOKEN' removes the lock on PATH if and only
> if the lock token is TOKEN. That resolves the race condition in
>
> $token = `svnadmin lslocks PATH`;
> if (inspect $token):
> system "svnadmin rmlocks PATH";

Ah! Makes great sense. Thanks!

Cheers,
-g
Received on 2012-01-06 22:09:49 CET

This is an archived mail posted to the Subversion Dev mailing list.