[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 5 Jan 2012 22:49:09 +0200

Thanks for the patches.

Matthijs Kooijman wrote on Thu, Jan 05, 2012 at 21:06:19 +0100:
> Patches are against svn trunk (r1227522), but also apply with just a
> single trivial conflict to 1.6.17.

> [[[
> Fix the get-location-segments.py example
>
> When trying to run the example, it throws:
>
> TypeError: Unexpected NULL parent pool on proxy object
>
> Somehow, the "_parent_pool" property wasn't initialized on the context.
> Not sure how this works, but creating a context using
> client.svn_client_create_context() instead of client.ctx_t() (which
> subversion/bindings/swig/python/tests/pool.py also does) fixes this
> error and makes the example work again.
>
> * tools/examples/get-location-segments.py
> Use client.svn_client_create_context instead of client.ctx_t.
>
> Patch by: Matthijs Kooijman <matthijs_at_stdin.nl>
> ]]]
> Index: subversion-trunk/tools/examples/get-location-segments.py
> ===================================================================
> --- subversion-trunk.orig/tools/examples/get-location-segments.py 2012-01-05 14:29:12.146977757 +0100
> +++ subversion-trunk/tools/examples/get-location-segments.py 2012-01-05 14:31:20.179645368 +0100
> @@ -124,7 +124,7 @@
> sys.exit(1)
>
> core.svn_config_ensure(None)
> - ctx = client.ctx_t()
> + ctx = client.svn_client_create_context()

This looks trivial so I'll apply it, but I'd like to note that
'patch -p1' rejects this for some reason.

> providers = [
> client.get_simple_provider(),
> core.svn_auth_get_ssl_server_trust_file_provider(),
Received on 2012-01-05 21:50:06 CET

This is an archived mail posted to the Subversion Dev mailing list.