[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1222522 - /subversion/branches/1.7.x/STATUS

From: Branko Čibej <brane_at_xbc.nu>
Date: Sat, 24 Dec 2011 18:18:18 +0100

On 24.12.2011 17:37, Daniel Shahaf wrote:
> Stefan Küng wrote on Sat, Dec 24, 2011 at 17:24:51 +0100:
>> Then why are there multiple statements like this in the svn code:
>> SVN_ERR_ASSERT_NO_RETURN(svn_dirent_is_absolute(local_abspath));
>> (example from libsvn_wc\util.c, line 197).
> Because the containing function doesn't return svn_error_t.

Which is exactly what I said earlier. As long as we have /any/ function
that does not return an error code, unless we can prove that it cannot
fail in a detectable manner, there's not even a theoretical chance of
removing such assertions.

-- Brane
Received on 2011-12-24 18:18:58 CET

This is an archived mail posted to the Subversion Dev mailing list.