[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [BUG+PATCH] Repository "corruption" when committing several versions of a huge file

From: Branko Čibej <brane_at_xbc.nu>
Date: Tue, 29 Nov 2011 16:57:56 +0100

On 29.11.2011 16:21, Philip Martin wrote:
> Martin Buck <mb-tmp-fhoirefvba.ncnpur.bet_at_gromit.dyndns.org> writes:
>
>> --- subversion-1.7.1/subversion/libsvn_fs_fs/fs_fs.c.orig 2011-10-19 19:28:55.000000000 +0200
>> +++ subversion-1.7.1/subversion/libsvn_fs_fs/fs_fs.c 2011-11-25 16:53:56.000000000 +0100
>> @@ -2575,7 +2575,7 @@
>>
>> svn_revnum_t base_revision;
>> apr_off_t base_offset;
>> - apr_size_t base_length;
>> + svn_filesize_t base_length;
>> };
>>
>> /* Read the next line from file FILE and parse it as a text
>> @@ -2636,7 +2636,7 @@
>> if (! str)
>> goto error;
>> SVN_ERR(svn_cstring_atoi64(&val, str));
>> - rep_args->base_length = (apr_size_t)val;
>> + rep_args->base_length = (svn_filesize_t)val;
> If base_length is made 64 bits perhaps we should pass it directly to
> svn_cstring_atoi64 and avoid the cast?

Either keep the cast, or remove svn_filesize_t and use apr_int64_t
instead of it.

-- Brane
Received on 2011-11-29 16:58:31 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.