Re: [PATCH] commit --include-externals (v2)
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 4 Nov 2011 11:22:50 +0000 (GMT)
Hi Neels. Brief response.
Looks like a good improvement.
svn_wc__committable_external_info_t: Use the new 'svn_kind_t' instead of svn_node_kind_t.
svn_client_commit6(): Could you extract the main chunk of added code as a separate function? That would help me (the reader) quickly understand how much of the local state it does *not* touch.
harvest_committables(): Would the 'is_explicit_target' parameter be better named something like 'include_file_externals'? I'm not sure if that would better reflect its purpose in that function; I haven't got my head around it well enough, so just asking.
svn_client_commit6(): In the doc string, of instead of "If A and B, all file respectively dir externals as defined ...", I suggest "If A and/or B, all file and/or dir externals (respectively) as defined by ...". Rationale: "respectively" isn't used as a conjunction word in English: <http://www.transblawg.eu/index.php?/archives/870-Resp.-and-other-non-existent-English-wordsNicht-existente-englische-Woerter.html>.
In the same doc string: mention the TODO about --depth=immediates skipping dir externals, that you documented inside the function.
svn_wc__committable_externals_below(): Document the 'immediates_only' parameter.
--- On Thu, 3/11/11, Neels J Hofmeyr <neels_at_elego.de> wrote:
> From: Neels J Hofmeyr <neels_at_elego.de>
This is an archived mail posted to the Subversion Dev mailing list.