Re: [PATCH] Update to SQLite amalgamation instructions.

Karl Fogel wrote on Fri, Oct 28, 2011 at 15:30:53 -0400:
> 'Daniel Shahaf' <d.s_at_daniel.shahaf.name> writes:
> > './get-deps.sh sqlite' works for me, right now.
>
> When you run configure, if it can't find the right SQLite it prints out
> a message with a URL where you can fetch it. Last night, when I did
> this, that message was wrong -- the URL it pointed to didn't exist.
>
> That was what I was trying to fix.
>

Yes. And I'm saying that we already have the correct URL elsewhere
in the code.

Anyway: we're looping, since I already made that point and I already
understand what problem you were trying to fix. Why don't you just fix
it, one way or the other? Neither of us wants configure to print
a broken URL.

> >How many places does the sqlite recommended versoin number live in?
> >get-deps.sh, build/ac-macros/sqlite.m4, and tools/dist/release.py?
> >May be nice to lose the duplication... or at least to index all those
> >places so we don't forget one of them when updating the others.
>
> I agree about the duplication of the version number, but it's a separate
> problem I think.

+1, CC'ing Hyrum so he notes this.
Received on 2011-10-28 21:44:25 CEST