[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1188774 - /subversion/trunk/subversion/libsvn_client/externals.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 26 Oct 2011 17:26:37 +0200

On Wed, Oct 26, 2011 at 05:17:36PM +0200, Bert Huijben wrote:
> > + /* Is DEFINING_ABSPATH now an unversioned directory we can
> > remove? */
> > + SVN_ERR(svn_wc_status3(&defining_status, ctx->wc_ctx,
> > defining_abspath,
> > + iterpool, iterpool));
> Defining abspath is the directory that contain(s/ed) the svn:externals property, not the parent of the externals directory. There may be several levels inbetween as you can define externals on any subdirectory level.
> The check should be on the parent of the external and probably recurse upwards.

I agree, good point.

> For the backport: I'm not sure if this is really a problem that we must fix. The same behavior applies to any unversioned directory.

It is pointless to leave the directory there. It will just cause tree
conflicts later when the user updates up or down to a revision where the
directory re-appears.

It's an edge-case, but it's worth doing IMO.
Received on 2011-10-26 17:27:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.