Re: svn commit: r1186283 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

Hyrum K Wright wrote on Wed, Oct 19, 2011 at 12:54:59 -0500:
> On Wed, Oct 19, 2011 at 12:44 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Wed, Oct 19, 2011 at 07:27:50PM +0200, Daniel Shahaf wrote:
> >> Please revert.  The if (1) is there to make merging the revprop-packing
> >> branch easier.
>
> I'm happy to revert, but as the current state appears to be temporary,
> what's the plan to change it / make it permanent?
>

On the revprop-packing branch those if (1)'s are all 'if is_packed_revprop()'.

The if (1)'s are on trunk because of the revprop-packing-via-sqlite code
that used to live on trunk: when pulling the feature, I made them into
'if (1)' rather than remove them entirely, to make merging easier in the
future.

> >> If you don't like the if (1) line, feel free to delete *just that line*
> >> and leave the {} block intact...
>
> It wasn't that line, actually, it was the duplicate return statements
> which initially led me to that function.
>

Oh. Is there a way we can write set_revision_proplist() on trunk such
that your compiler or analyser doesn't complain about it?

> > I think I also removed this once.
> > Can you please add a comment if you intend to keep it?
>
> +1
>

Done.

> -Hyrum
>
>

Thanks,

Daniel
Received on 2011-10-19 20:21:00 CEST