[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1186283 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 19 Oct 2011 12:54:59 -0500

On Wed, Oct 19, 2011 at 12:44 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Wed, Oct 19, 2011 at 07:27:50PM +0200, Daniel Shahaf wrote:
>> Please revert.  The if (1) is there to make merging the revprop-packing
>> branch easier.

I'm happy to revert, but as the current state appears to be temporary,
what's the plan to change it / make it permanent?

>> If you don't like the if (1) line, feel free to delete *just that line*
>> and leave the {} block intact...

It wasn't that line, actually, it was the duplicate return statements
which initially led me to that function.

> I think I also removed this once.
> Can you please add a comment if you intend to keep it?

+1

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2011-10-19 19:55:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.