[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Minor patch suggestion:

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 17 Oct 2011 13:42:44 +0200

> -----Original Message-----
> From: Mat Booth [mailto:mat.booth_at_wandisco.com]
> Sent: maandag 17 oktober 2011 12:26
> To: Peter Samuelson
> Cc: dev_at_subversion.apache.org
> Subject: Re: Minor patch suggestion:
>
> On 14 October 2011 18:25, Peter Samuelson <peter_at_p12n.org> wrote:
> >
> > [Mat Booth]
> >> --- subversion/libsvn_subr/cmdline.c †(revision 1183368)
> >> +++ subversion/libsvn_subr/cmdline.c †(working copy)
> >> @@ -32,8 +32,10 @@
> >> †#include <fcntl.h>
> >> †#include <unistd.h>
> >> †#else
> >> +#if _MSC_VER >= 1400
> >> †#include <crtdbg.h>
> >> †#endif
> >> +#endif
> >
> > Looks reasonable ... but then when I scrolled down the file a bit, I
> > found this:
> >
> > #if _MSC_VER >= 1400
> > †/* ### This should work for VC++ 2002 (=1300) and later */
> >
> > So, what should it be? †1300 or 1400?

I just tested it for 1400 (Visual Studio 2005) and newer, because I have no
Visual Studio 2002 or 2003 installed. If somebody confirms that it works
correctly it should be enabled for that release, but now it just works as
before (I added that block) in that version.

I don't know anybody that still does real Subversion work with the 2002/2003
Visual Studio versions.
Visual Studio 2005, 2008 and 2010 are the most common releases and then
Visual C++ 6.0 (From 1998). But apache httpd and some other old projects
still require Visual C++ 6.0 (from 1998).

AnkhSVN has about 1000 users that still use Visual Studio 2002/2003. This
number is measurable in our update process, but nothing compared to our
total user base. (We have no numbers on VC 6.0 usage)

        Bert
Received on 2011-10-17 13:43:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.