[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Minor patch suggestion:

From: Mat Booth <mat.booth_at_wandisco.com>
Date: Mon, 17 Oct 2011 11:25:31 +0100

On 14 October 2011 18:25, Peter Samuelson <peter_at_p12n.org> wrote:
> [Mat Booth]
>> --- subversion/libsvn_subr/cmdline.c  (revision 1183368)
>> +++ subversion/libsvn_subr/cmdline.c  (working copy)
>> @@ -32,8 +32,10 @@
>>  #include <fcntl.h>
>>  #include <unistd.h>
>>  #else
>> +#if _MSC_VER >= 1400
>>  #include <crtdbg.h>
>>  #endif
>> +#endif
> Looks reasonable ... but then when I scrolled down the file a bit, I
> found this:
> #if _MSC_VER >= 1400
>  /* ### This should work for VC++ 2002 (=1300) and later */
> So, what should it be?  1300 or 1400?
> --
> Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

Good question, I don't know. I don't have access to that compiler and
I didn't want to change it 1300 without testing it. Maybe rhuijben can
clairfy? (His name is on the svn blame for that line.)

Mat Booth
Software Engineer
WANdisco, Inc.
uberSVN: Subversion Made Easy
Everything you need to deploy Subversion in the Enterprise
Subversion community
Read our blogs
Follow us on Twitter
MAY BE PRIVILEGED.  If this message was misdirected, WANdisco, Inc.
and its subsidiaries, ("WANdisco") does not waive any confidentiality
or privilege.  If you are not the intended recipient, please notify us
immediately and destroy the message without disclosing its contents to
anyone.  Any distribution, use or copying of this e-mail or the
information it contains by other than an intended recipient is
unauthorized.  The views and opinions expressed in this e-mail message
are the author's own and may not reflect the views and opinions of
WANdisco, unless the author is authorized by WANdisco to express such
views or opinions on its behalf.  All email sent to or from this
address is subject to electronic storage and review by WANdisco.
Although WANdisco operates anti-virus programs, it does not accept
responsibility for any damage whatsoever caused by viruses being
Received on 2011-10-17 12:26:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.