[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1170324 - /subversion/trunk/subversion/include/svn_editor.h

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 13 Sep 2011 19:58:22 -0400

On phone. Sorry for terse.

On Sep 13, 2011 9:54 AM, <hwright_at_apache.org> wrote:
>
> Author: hwright
> Date: Tue Sep 13 19:54:14 2011
> New Revision: 1170324
>
> URL: http://svn.apache.org/viewvc?rev=1170324&view=rev
> Log:
> * subversion/include/svn_editor.h
> (svn_editor_set_props): Add a couple of notes.
>
> Modified:
> subversion/trunk/subversion/include/svn_editor.h
>
> Modified: subversion/trunk/subversion/include/svn_editor.h
> URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_editor.h?rev=1170324&r1=1170323&r2=1170324&view=diff
>
==============================================================================
> --- subversion/trunk/subversion/include/svn_editor.h (original)
> +++ subversion/trunk/subversion/include/svn_editor.h Tue Sep 13 19:54:14
2011
> @@ -773,7 +773,14 @@ svn_editor_add_absent(svn_editor_t *edit
> *
> * Set or change properties on the existing node at @a relpath.
> * ### TODO @todo Does this send *all* properties, always?

Yes.

> + * ### HKW: The purist in me says "yes", but the pragmatist says "no".
> + * ### Writing a backward compat shim is going to be next to impossible,
> + * ### since we've no way to know about existing props while receiving
> + * ### props from the delta editor.

An incoming propdelta always knows the target to apply against. Your shim
must fetch the target props, compute the delta, and call the right
callbacks.

> + * ###
> * ### TODO @todo What is REVISION for?
> + * ### HKW: This is puzzling to me as well...

What rev are you attempting to set props against? Are you out of date?

> + * ###
> * ### what about "entry props"? will these still be handled via
> * ### the general prop function?
> *
>
>
Received on 2011-09-14 01:58:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.