[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1170324 - /subversion/trunk/subversion/include/svn_editor.h

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 14 Sep 2011 01:38:36 +0300

(about svn_editor_set_props())

hwright_at_apache.org wrote on Tue, Sep 13, 2011 at 19:54:14 -0000:
> Author: hwright
> Date: Tue Sep 13 19:54:14 2011
> New Revision: 1170324
>
> URL: http://svn.apache.org/viewvc?rev=1170324&view=rev
> Log:
> * subversion/include/svn_editor.h
> (svn_editor_set_props): Add a couple of notes.
>
> Modified:
> subversion/trunk/subversion/include/svn_editor.h
>
...
> * Set or change properties on the existing node at @a relpath.
> * ### TODO @todo Does this send *all* properties, always?

I'd answer "As written, yes" since the props parameter is an apr_hash_t
(and the docstring doesn't make special arrangements for representation
of propdels within that).

> + * ### HKW: The purist in me says "yes", but the pragmatist says "no".
> + * ### Writing a backward compat shim is going to be next to impossible,
> + * ### since we've no way to know about existing props while receiving
> + * ### props from the delta editor.
> + * ###

For example, 'svn propset pn pv URL' does not know the remaining
properties of URL.

That said: isn't this discussion similar to the discussion from last
week about whether svn_editor_set_text() should be taking a full
contents stream or a delta stream? Does the resolution of that
discusion apply here?

> * ### TODO @todo What is REVISION for?
> + * ### HKW: This is puzzling to me as well...
> + * ###
> * ### what about "entry props"? will these still be handled via
> * ### the general prop function?
> *
>
Received on 2011-09-14 00:39:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.