Re: svn commit: r1166555 - /subversion/trunk/subversion/libsvn_ra_svn/cyrus_auth.c

On Thu, Sep 08, 2011 at 04:37:00PM +0200, Stefan Sperling wrote:
> On Thu, Sep 08, 2011 at 05:20:20PM +0300, Daniel Shahaf wrote:
> > Semi-related question: how does this fix interact with this part of
> > svnserve's main():
> >
> > /* Use a subpool for the connection to ensure that if SASL is used
> > * the pool cleanup handlers that call sasl_dispose() (connection_pool)
> > * and sasl_done() (pool) are run in the right order. See issue #3664. */
> > connection_pool = svn_pool_create(pool);
> > conn = svn_ra_svn_create_conn2(NULL, in_file, out_file,
> > params.compression_level,
> > connection_pool);
> > svn_error_clear(serve(conn, &params, connection_pool));
> > exit(0);
> >
> > ?
> >
> > Both are SASL pool lifetime issues. Is the above hunk still needed
> > after the change below?
>
> Quite likely still needed.

Also, note that the above fix was server-side, while the new fix
is on the client side :)
Received on 2011-09-08 16:39:36 CEST