On Thu, Sep 08, 2011 at 05:20:20PM +0300, Daniel Shahaf wrote:
> Semi-related question: how does this fix interact with this part of
> svnserve's main():
> /* Use a subpool for the connection to ensure that if SASL is used
> * the pool cleanup handlers that call sasl_dispose() (connection_pool)
> * and sasl_done() (pool) are run in the right order. See issue #3664. */
> connection_pool = svn_pool_create(pool);
> conn = svn_ra_svn_create_conn2(NULL, in_file, out_file,
> svn_error_clear(serve(conn, ¶ms, connection_pool));
> Both are SASL pool lifetime issues. Is the above hunk still needed
> after the change below?
Quite likely still needed.
The above was a crash that happened at exit(0) time, and only when svnserve
was run in inetd mode. I don't know how the reporters of the new bug are
running svnserve, but I would guess that it's a different bug.
In any case, even if this was now redundant, there is no harm in
keeping this as it is.
Received on 2011-09-08 16:37:47 CEST