AW: Recurse into same-repos externals at commit time.

Hi,

Von: Neels J Hofmeyr [mailto:neels_at_elego.de]
>
> On 08/29/2011 05:48 PM, C. Michael Pilato wrote:
> > No sweat. 'svn commit --include-externals' sounds like a fine plan.
>
> +1 and volunteering.

Great, thanks!
 
> So by default, *all* externals shall be skipped from commit (dir and file
> externals alike).
>
> When --include-externals is passed to 'svn commit', *all* externals are
> recursed into (dir and file externals alike).
>
> However, an external that has a specific peg revision (file and dir
> externals alike) is never recursively included in commit.
>
> Questions remain about passing externals explicitly:
>
> - when an external is passed as explicit target, still require --include-
> externals?

IMHO: Do not require --include-externals. If I only want to commit a single file which happens to reside inside an external subdirectory, and give that file explicitly, I do not want to say "--include-externals".

> - when a *pegged* external is passed as explicit target (and say even if -
> -include-externals is passed), should we *still* refuse to commit it?

Here, I say yes. We also do not allow to commit when the working copy is not at head revision.

> I'd say yes (thinking of 'svn commit *') and yes (thinking of avoiding
> inconsistent external state as seen with file externals, and of changes
> snapping back to peg as seen with dir externals).
>
> If user wants to commit to a *pegged* external, user should just use a
> different, non-externals-ized checkout.

Ack.

Best regards

Markus Schaber

___________________________
We software Automation.

3S-Smart Software Solutions GmbH
Markus Schaber | Developer
Memminger Str. 151 | 87439 Kempten | Germany | Tel. +49-831-54031-0 | Fax +49-831-54031-50

Email: m.schaber@3s-software.com | Web: http://www.3s-software.com
CoDeSys internet forum: http://forum.3s-software.com
Download CoDeSys sample projects: http://www.3s-software.com/index.shtml?sample_projects

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915
Received on 2011-08-30 08:56:31 CEST