Re: bring on your concerns about svn:hold, please

On 08/23/2011 01:22 AM, Neels J Hofmeyr wrote:
> On 08/23/2011 12:00 AM, Greg Stein wrote:
>> 'svn commit foo' will *never* work if svn:hold is set on the file. I
>> find that awfully confusing, until I realize that somebody applied
>> svn:hold to the file.
>
> That's actually an intended part of the feature, and it is
> switch-off-and-rule-out-able forever by a simple pre-commit hook. With no
> svn:hold allowed to be committed, it remains usable locally. I don't see
> *any* problem here.

Actually, if you do still see a problem, what about adding another option
--commit-global-hold (or whatever the name) without which even --do-not-hold
keeps the 'svn:hold' property out of the repository.

I mean if 'svn:hold' is set locally on 'foo' and 'foo' gets committed with
--do-not-hold, the local text and other mods *are* committed, but only the
'svn:hold' propset is still held back.

Add --commit-global-hold to do leak it into the repos, definitely
intentionally. Just to add another threshold before sending 'hold' to other WCs.

I'd gladly implement this if this list thinks it would be good to add this
step. (IMO it's not really necessary.)

~Neels