[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1156756 - /subversion/trunk/subversion/libsvn_client/patch.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 12 Aug 2011 00:48:53 +0200

> -----Original Message-----
> From: stsp_at_apache.org [mailto:stsp_at_apache.org]
> Sent: donderdag 11 augustus 2011 21:29
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1156756 -
> /subversion/trunk/subversion/libsvn_client/patch.c
>
> Author: stsp
> Date: Thu Aug 11 19:29:25 2011
> New Revision: 1156756
>
> URL: http://svn.apache.org/viewvc?rev=1156756&view=rev
> Log:
> * subversion/libsvn_client/patch.c
> (resolve_target_path): Rename LOCAL_ABSPATH parameter to the more
> obvious
> WCROOT_ABSPATH. It is the absolute path of the working copy root.
> (choose_target_filename): Rename BASE_DIR parameter to
> WCROOT_ABSPATH for
> the same reason.

Looking at the callers this argument is not necessary the real wcroot, but just the directory where the path is applied to.
(svn_client_patch performs baton.abs_wc_path = wc_dir_abspath which is then used for wcroot_abspath for this function).

As I don't think the working copy root is the only valid patch target, I think this argument should have a different name.

        Bert
Received on 2011-08-12 00:49:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.