Re: svn commit: r1154393 - in /subversion/branches/fs-py/subversion: libsvn_fs_py/fs.c libsvn_fs_py/fs.h libsvn_fs_py/fs_fs.c libsvn_fs_py/py_util.c libsvn_fs_py/py_util.h python/svn/fs.py

On Sat, Aug 6, 2011 at 6:19 AM, Greg Stein <gstein_at_gmail.com> wrote:
> On Fri, Aug 5, 2011 at 18:13,  <hwright_at_apache.org> wrote:
>> Author: hwright
>> Date: Fri Aug  5 22:13:44 2011
>> New Revision: 1154393
>>
>> URL: http://svn.apache.org/viewvc?rev=1154393&view=rev
>> Log:
>> On the fs-py branch:
>> Load the FS Python module, and call a stub create method on it when the
>> cooresponding C API is called.
>
> From my quick perusal... it seems that you might not be handling
> thread states and the GIL. Have I missed something?

Certainly not. I've read the relevant documentation regarding the GIL
and thread states, but am still trying to grok how to apply it to this
case. Most of the docs and examples are written for calling C from
Python (see [1]), rather than embedding Python in C. I'm not exactly
sure how this changes the semantics.

At some point, I'll need to start worrying about thread states and the
GIL, and while I'm happy to experiment and learn via trial and error,
if you've some insights, I'd certainly welcome them.

-Hyrum

[1] http://docs.python.org/c-api/init.html#thread-state-and-the-global-interpreter-lock

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/