Re: svn commit: r1148693 - /subversion/branches/1.7.x/STATUS

On Wed, Jul 20, 2011 at 10:49:03AM -0000, rhuijben_at_apache.org wrote:
> + * r1148566
> + Fix a memory leak in svn merge.
> + Justification:
> + Memory leaks are bad.
> + Votes:
> + +1: stsp
> + -0: rhuijben (r1148588 fixes the immediate problems and this code can use
> + a bit more cleanup before backporting. See also the
> + dev_at_s.a.o thread for gstein's concerns)

Hmmm.. what "immediate problems" is r1148588 fixing?
Are you suggesting that r1148588 alone fixes the memory leak?
Because it doesn't.

Have you tried the merge described in the log message of r1148566
with r1148566 backed out? The leak is still present when I try this.

See also my reply to gstein's mail:
http://svn.haxx.se/dev/archive-2011-07/0583.shtml

Of course we can clean things up more, but that is no reason
not to merge r1148566 into 1.7.x.
Received on 2011-07-20 13:08:46 CEST