[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_checksum_to_cstring_display() Re: svn commit: r1146270 - /subversion/branches/1.7.x/STATUS

From: Daniel Shahaf <danielsh_at_apache.org>
Date: Wed, 13 Jul 2011 23:00:50 +0300

C. Michael Pilato wrote on Wed, Jul 13, 2011 at 15:54:31 -0400:
> On 07/13/2011 03:46 PM, Daniel Shahaf wrote:
> > cmpilato_at_apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -0000:
> >> * r1146214
> >> Handle NULL inputs when stringifying svn_checksum_t.
> >> @@ -38,6 +39,7 @@ Candidate changes:
> >> Avoids segfaults.
> >> Votes:
> >> +1: danielsh
> >> + -0: cmpilato (problem is with callers, not implementation)
> >
> > Do you want to convert the 'return NULL;' into an assertion then?
>
> Why? (I honestly don't see what's motivating any change at all here.) A
> segfault in the function because of a NULL pointer deref; a segfault in the
> caller because it tries to use what should be a string but is actually a
> NULL (despite the docstring not foretelling this behavior, even); an
> assert() ... these all look the same to me. :-)

SVN_ERR_ASSERT, not assert(). I assume that an SVN_ERR_ASSERT is better
than SIGSEGV.
Received on 2011-07-13 22:01:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.