Noorul Islam K M wrote on Thu, Jun 23, 2011 at 15:25:37 +0530:
> "Bert Huijben" <bert_at_qqmail.nl> writes:
>
> >> -----Original Message-----
> >> From: Noorul Islam K M [mailto:noorul_at_collab.net]
> >> Sent: donderdag 23 juni 2011 5:44
> >> To: Daniel Shahaf
> >> Cc: Julian Foad; Subversion; Bert Huijben
> >> Subject: Re: [PATCH] Fix for issue 3813
> >>
> >> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
> >>
> >> > Looks like Bert committed a functionally equivalent fix as part of
> > r1138474.
> >> >
> >>
> >> Bert,
> >>
> >> May I know why this patch was not considered? Looking at the commit I
> >> could not see any difference.
> >
> > Applying a one line patch takes me 5 times more time than just editing the
> > code. And as the final whitespace (and comment) didn't match your original
> > patch, adding a patch by wasn't really appropriate.
> >
>
> I thought if the patch was incorrect, I might be getting some feedback.
>
In this case your feedback is the interdiff between what you sent and
what Bert applied. (Before I became a committer it was my habit to
always study the interdiff, in addition to whatever comments I might
have received on dev@.)
> > Discussion on irc showed that we couldn't just apply the patch without the
> > additional work from Stefan as that would open a window where somebody could
> > look at otherwise hidden files. (I assumed he would apply your patch after
> > that, but later I just applied the change anyway)
> >
> > I just added a 'found by' to the log message of r1138474.
> >
>
> It was actually found by Daniel.
>
I have to agree with Noorul here; I've adjusted the log message to
'Patch by'.
> Thanks and Regards
> Noorul
Received on 2011-06-23 14:08:24 CEST