[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Windows build, nonexistent functions

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 29 May 2011 03:54:03 -0400

On May 29, 2011 2:55 AM, "Stefan Küng" <tortoisesvn_at_gmail.com> wrote:
> On 29.05.2011 04:31, Greg Stein wrote:
>> On May 28, 2011 1:39 PM, "Stefan Küng" <tortoisesvn_at_gmail.com
>> <mailto:tortoisesvn_at_gmail.com>> wrote:
>> >
>> > I did a grep search for those functions, and the only files they
>> showed up were the headers, no other files contained those function
>> names. So it's not because of preprocessor conditionals.
>> >
>> > I'll wait until tomorrow. If there are no objections until then, I'll
>> commit a change which removes those.
>> For the conflict_skel functions, please wrap them in #if 0, rather then
>> deleting them. We are going to use them for 1.8.
>> The other two... as you wish.
> An #if 0 won't help with extractor.py at all. It will still extract the

Eep. Good point.

> If the functions are needed in 1.8, can't we just add them once they're
really needed?

Sure. My concern was just getting them back when needed. I guess we can just
rely on 'svn log' and track down the right revision.

Received on 2011-05-29 09:54:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.