Re: [PATCH] Server-transmitted "final SHA1 checksums" (Was: "large number of large binary files in subversion")

On 05/24/2011 11:47 AM, Stefan Sperling wrote:
> On Tue, May 24, 2011 at 11:30:39AM -0400, C. Michael Pilato wrote:
>> I held off on committing my RA work because there were no consumers. But
>> I've still considering making the change because a) there's no penalty for
>> doing so, and b) maybe if we add the requisite client-side magic in 1.8, 1.7
>> servers would already be advertising the sha1 checksum that code would need.
>
> Sounds like an excellent plan to me, if there really is no penalty.

I call the FS function in a way that says, "give me the SHA1 if you have it
handy, but don't go calculate it if you don't." So, a little bit of FS
query cost, some additional bytes on the wire, but that's about it.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand