[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1124382 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_client/merge.c libsvn_ra_neon/commit.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 24 May 2011 14:30:40 -0400

On 05/19/2011 05:33 AM, Bert Huijben wrote:
>> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]


>> -1 unless you update svn_client_merge4()'s docstring accordingly, since
>> it promises a specific error code here.
> And I think the error code needs another _ between UPDATE and REQUIRED.

I took care of these concerns on steveking's behalf in r1127198. (I rather
doubt that he follows this list thoroughly, so in the future we should
probably Cc: him on reviews of his commits.)

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-05-24 20:31:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.