[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1124382 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_client/merge.c libsvn_ra_neon/commit.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 19 May 2011 11:33:22 +0200

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> Sent: donderdag 19 mei 2011 10:19
> To: dev_at_subversion.apache.org
> Cc: commits_at_subversion.apache.org
> Subject: Re: svn commit: r1124382 - in /subversion/trunk/subversion:
> include/svn_error_codes.h libsvn_client/merge.c libsvn_ra_neon/commit.c
>
> steveking_at_apache.org wrote on Wed, May 18, 2011 at 18:58:50 -0000:
> > @@ -9015,7 +9015,7 @@ ensure_wc_is_suitable_merge_target(const
> > }
> >
> > if (min_rev != max_rev)
> > - return
> svn_error_createf(SVN_ERR_CLIENT_NOT_READY_TO_MERGE, NULL,
> > + return
> svn_error_createf(SVN_ERR_CLIENT_MERGE_UPDATEREQUIRED, NULL,
> > _("Cannot merge into mixed-revision
working "
> > "copy [%lu:%lu]; try updating
first"),
> > min_rev, max_rev);
>
> -1 unless you update svn_client_merge4()'s docstring accordingly, since
> it promises a specific error code here.

And I think the error code needs another _ between UPDATE and REQUIRED.

        Bert
Received on 2011-05-19 11:34:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.