[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1124207 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 20 May 2011 13:19:21 +0100

Daniel Shahaf wrote:
> Perhaps change 'svnserve -M' too, for consistency?
>
> stefan2_at_apache.org wrote on Wed, May 18, 2011 at 11:53:54 -0000:
> > Make the SVNInMemoryCacheSize mod_dav_svn module setting interpret
> > its parameter value as "kB" instead of "MB". This is more in line with how
> > all other Apache settings are being handled.
> >
> > * subversion/mod_dav_svn/mod_dav_svn.c
> > (SVNInMemoryCacheSize_cmd): interpret parameter as "kB" instead of "MB"
> > (cmds): update short user doc string
[...]
> > Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
[...]
> > - settings.cache_size = value * 0x100000;
> > + settings.cache_size = value * 0x400;
> >
> > svn_set_cache_config(&settings);
> >
> > @@ -931,8 +931,8 @@ static const command_rec cmds[] =
> > /* per server */
> > AP_INIT_TAKE1("SVNInMemoryCacheSize", SVNInMemoryCacheSize_cmd, NULL,
> > RSRC_CONF,
> > - "specifies the maximum size im MB per process of Subversion's "
> > - "in-memory object cache (default value is 16; 0 deactivates "
> > + "specifies the maximum size im kB per process of Subversion's "

Not introduced by this patch, but: "im kB" -> "in kB".

> > + "in-memory object cache (default value is 16384; 0 deactivates "
> > "the cache)."),

- Julian
Received on 2011-05-20 14:19:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.