[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c libsvn_wc/upgrade.c

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 19 May 2011 08:11:33 +0200

On Wed, May 18, 2011 at 22:28, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 05/18/2011 08:47 PM, steveking_at_apache.org wrote:
>> Author: steveking
>> Date: Wed May 18 18:47:42 2011
>> New Revision: 1124375
>> URL: http://svn.apache.org/viewvc?rev=1124375&view=rev
>> Log:
>> Resolve issue #3887, "Eliminate client-specific suggestions from shared
>> libraries", by changing the error messages.
>> * subversion/libsvn_client/checkout.c
>>   (svn_client__checkout_internal): remove reference to 'svn update'
>> * subversion/libsvn_wc/upgrade.c
>>   (upgrade_to_wcng): remove reference to 'svn cleanup'
> Hrm.  I rather expected that this change would have two components:
> 1.  Remove references to 'svn' subcommands from share lib error messages.
> 2.  From the same places, return unique-enough error codes that the client
> catches so *it* can give those same client-specific suggestions.
> Looks like only step #1 was done here.  Were you intending to take this further?

In checkout.c, I'm pretty sure an update doesn't help: why would an
update do anything good in case of a failed checkout because a folder
is already a working copy for a different url? IMHO that update hint
was wrong in the first place. --> an update does not change the fact
that there's a working copy from another repo in the way.

In upgrade.c, a different error code won't help since the cleanup has
to be done with an 1.6 client (i.e., a client with an older version).
So a client simply can not act on this and do the cleanup itself.


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
Received on 2011-05-19 08:12:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.