Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c libsvn_wc/upgrade.c

On 05/18/2011 08:47 PM, steveking_at_apache.org wrote:
> Author: steveking
> Date: Wed May 18 18:47:42 2011
> New Revision: 1124375
>
> URL: http://svn.apache.org/viewvc?rev=1124375&view=rev
> Log:
> Resolve issue #3887, "Eliminate client-specific suggestions from shared
> libraries", by changing the error messages.
>
> * subversion/libsvn_client/checkout.c
> (svn_client__checkout_internal): remove reference to 'svn update'
> * subversion/libsvn_wc/upgrade.c
> (upgrade_to_wcng): remove reference to 'svn cleanup'

Hrm. I rather expected that this change would have two components:

1. Remove references to 'svn' subcommands from share lib error messages.
2. From the same places, return unique-enough error codes that the client
catches so *it* can give those same client-specific suggestions.

Looks like only step #1 was done here. Were you intending to take this further?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand