[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Wed, 18 May 2011 11:38:12 +0200

On Wed, May 18, 2011 at 11:20 AM, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: Greg Stein [mailto:gstein_at_gmail.com]
>> Sent: woensdag 18 mei 2011 11:16
>> To: Bert Huijben
>> Cc: dev_at_subversion.apache.org; Hyrum K Wright
>> Subject: Re: svn commit: r1104610 - in
>> /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h
>> On Wed, May 18, 2011 at 05:11, Bert Huijben <bert_at_qqmail.nl> wrote:
>> >> -----Original Message-----
>> >> From: Greg Stein [mailto:gstein_at_gmail.com]
>> >> Sent: woensdag 18 mei 2011 11:07
>> >> To: dev_at_subversion.apache.org
>> >> Cc: Hyrum K Wright
>> >> Subject: RE: svn commit: r1104610 - in
>> >> /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h
>> >>
>> >> No, we said if somebody breaks the build, then it can be reverted.
>> >>
>> >> Breaking the tests does not qualify. You were out of line. I just got
>> >> telling off people in Lucene-land for this. I also said that if it were
> up
>> >> to me, I would warn somebody about the anti social behavior once, and
>> >> remove
>> >> their commit privs on the second time. It is THAT much of a problem in
> the
>> >> community dynamics.
>> >>
>> >> Don't do that again.
>> >
>> > Does breaking all the property handling code qualify?
>> No.
>> If you felt the changes were interfering with your work, then you can
>> always apply a reversion to your local working copy to continue your
>> work. Then, when Hyrum got back online, he could figure out what he
>> did and how to move it forward.
>> For most people, his changes may have had no impact at all.
> Well, yesterday afternoon I had 4 individuals asking me in person why their
> test were broken, and this was why.
> (There was no problem in neon after all).

Did a similar discussion happen on the mailing list? If I doesn't
happen on the list, it's just hearsay. (Incidentally, that's why
we're having this discussion on the mailing, rather than in person,
even though we're in the same room.)

I'll readily claim the fault with breaking the tests. All I'm asking
is that in the future such problems are discussed, rather than
reverted out-of-hand. I appreciate you fixing them, but I'd hoped to
learn something from the experience, rather than just having the
problem fixed for me.

> If I would have committed a change with similar breakage you would have
> shouted at me.
> And because Hyrum is our release manager, or maybe because he pays you some
> checks, you threat him differently?

For the record, I don't pay any checks to Greg (and he has shouted at
me a number of times).

Received on 2011-05-18 11:38:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.