Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

Greg Stein wrote on Tue, May 17, 2011 at 11:19:40 -0400:
> On Tue, May 17, 2011 at 10:46, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > gstein_at_apache.org wrote on Wed, May 11, 2011 at 04:06:57 -0000:
> >> +static svn_error_t *
> >> +with_finalization(void *baton,
> >
> > @a BATON is unused.
>
> Yeah. I put it in there simply based on precedent and our consistent
> pattern for stuff like this. Nobody seems to need or use it yet.
>

I'm not particularly surprised that no one uses a parameter which the
function's body (definition) doesn't use.

In other words: @a BATON is not paired with any callback type
(pointer-to-function type), so how would it possibly be used?

> > Could you add a docstring please?  It seems that you call TXN_CB within
> > a txn, then call WORK_CB (odd name IMO) with NOTIFY_FUNC, then run
> > the FINALIZE_IDXth statement...
>
> Sure.
>

Thanks.

> Cheers,
> -g
Received on 2011-05-17 17:26:34 CEST