Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

On Tue, May 17, 2011 at 10:46, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> gstein_at_apache.org wrote on Wed, May 11, 2011 at 04:06:57 -0000:
>> +static svn_error_t *
>> +with_finalization(void *baton,
>
> @a BATON is unused.

Yeah. I put it in there simply based on precedent and our consistent
pattern for stuff like this. Nobody seems to need or use it yet.

> Could you add a docstring please?  It seems that you call TXN_CB within
> a txn, then call WORK_CB (odd name IMO) with NOTIFY_FUNC, then run
> the FINALIZE_IDXth statement...

Sure.

Cheers,
-g
Received on 2011-05-17 17:20:09 CEST