[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Vetos in 1.6.x branch -- and how they impact trunk

From: Mark Phippard <markphip_at_gmail.com>
Date: Tue, 17 May 2011 09:48:07 -0400

There are some vetos in the 1.6.x branch that seem like they are
questioning the change, not just whether it was a candidate for
backport. What does that mean for trunk and 1.7? Here are the items
I am thinking of (leaving out the items that were vetoed only because
they were not considered appropriate for a fix release):

 * r878078, r878088, r878102, r878196
   Make KWallet window attached to terminal window.
     Without this change, KWallet window can appear behind terminal window
     and is left after killing terminal.
     +1: arfrever
     -0: peters
     -1: rhuijben ("/proc/%ld/stat" is ugly and Linux-specific -
                   would just getenv("WINDOWID") work instead?)
     -1: stsp (I've removed the Linux-specific code from trunk in r1002144
               and r1002151, so trunk code only relies on getenv("WINDOWID").
               I would +1 a backport that also merges these revisions).

 * r921453, r927184, r927243
   Fix reopened issue #3020 'Reflect dropped/renumbered revisions in
   svn:mergeinfo data during svnadmin load'
     Prior to this fix, when loading a partial dump with mergeinfo, the
     resulting mergeinfo in the target repository could refer to non-existent
     revisions or revisions that have nothing to do with the merge source
     in the original repository. The original fix for issue assumed that
     the dump stream was for a complete repository.
     r921453 and 927184 are tests, r927243 is the fix.
     +1: kameshj
     -1: pburba (There is a regression with this fix, see

 * r933194
   Fix for issue #2753
   SVNListParentPath feature doesn't work when svn authz is used.
     This issue is waiting for resolution for more than 3 years.
     See discussion at http://svn.haxx.se/dev/archive-2010-04/0275.shtml
     -1: cmpilato (pending results of aforemented discussion)

 * r879766
   Fix issue #3498: Subversion password stores freeze Eclipse
     All subclipse users are in great need of this.
     Resolves a minor conflict in libsvn_auth_gnome_keyring/gnome_keyring.c
     where the code changed was refactored on trunk.
     +1: stylesen
     +0: julianfoad (reviewed, not tested)
     -0: rhuijben (needs more explanation: The not-interactive and no
                   callback code paths should be more similar if the code
                   works correctly. I think the not interactive code path
                   needs the same fix).
     -1: markphip (tested multiple builds of this and never saw it work).

NOTE: I included this last item, but I do not think the attempt to
fix this problem made things any worse. But the problem it was trying
to fix is still a real problem.

Mark Phippard
Received on 2011-05-17 15:48:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.