Re: svn commit: r1101091 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

Stefan Fuhrmann <eqfox_at_web.de> writes:

> On 09.05.2011 18:43, Philip Martin wrote:
>> stefan2_at_apache.org writes:
>>
>>> Author: stefan2
>>> Date: Mon May 9 16:28:16 2011
>>> New Revision: 1101091
>>> (svn_cache__membuffer_cache_create): formatting fixes; add missing cast
>>> - c = apr_palloc(pool, segment_count * sizeof(*c));
>>> + c = (svn_membuffer_t *)apr_palloc(pool, segment_count * sizeof(*c));
>> Why is that cast necessary?
>>
> The Microsoft compiler issued a warning here and
> the explicit cast silences it. Maybe, it's a C99 thing?
> Curiously, it would not generate a warning before
> when the line read
>
> svn_membuffer_t *c = apr_palloc(...)

It's allowed by C99. Sounds like a compiler bug. We have dozens of
other calls of the form

  variable = apr_palloc(...);

Is this the only one that causes a warning?

-- 
Philip